Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Release owner section to maintainers #1612

Merged
merged 3 commits into from
Feb 10, 2022

Conversation

peternied
Copy link
Member

Description

Describing the intention behind being a release owner and approaches to different situations that occur during the a release.

Issues Resolved

In addition to several items from #1258

  • How to get help on a critical issue
  • How to conduct a retrospective
  • How to correct mistakes

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Describing the intention behind being a release owner and
approaches to different situations that occur during the a release.

Signed-off-by: Peter Nied <petern@amazon.com>
@peternied peternied requested a review from a team as a code owner February 10, 2022 00:15
@peternied
Copy link
Member Author

This PR differs from #1459 as it written to be higher level overview and less tactical.

#1459 has a ton of great content that would be good to see in the release template

@peternied peternied added the documentation Improvements or additions to documentation label Feb 10, 2022
@peternied peternied self-assigned this Feb 10, 2022
Copy link
Member

@dblock dblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The content is fine. I would do a proof read of it and try to remove fillers and such to make it more concise.

MAINTAINERS.md Outdated Show resolved Hide resolved
MAINTAINERS.md Outdated Show resolved Hide resolved
MAINTAINERS.md Outdated Show resolved Hide resolved
MAINTAINERS.md Outdated Show resolved Hide resolved
Signed-off-by: Peter Nied <petern@amazon.com>
@codecov-commenter
Copy link

codecov-commenter commented Feb 10, 2022

Codecov Report

Merging #1612 (42cad86) into main (33d2840) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##               main    #1612   +/-   ##
=========================================
  Coverage     94.66%   94.67%           
  Complexity       13       13           
=========================================
  Files           162      163    +1     
  Lines          3433     3435    +2     
  Branches         21       21           
=========================================
+ Hits           3250     3252    +2     
  Misses          180      180           
  Partials          3        3           
Impacted Files Coverage Δ
tests/jenkins/jobs/DownloadFromS3_Jenkinsfile 100.00% <0.00%> (ø)
src/run_sign.py 95.45% <0.00%> (+0.21%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33d2840...42cad86. Read the comment docs.

Signed-off-by: Peter Nied <petern@amazon.com>
@peternied peternied merged commit aa53d94 into opensearch-project:main Feb 10, 2022
@dblock dblock mentioned this pull request Feb 11, 2022
1 task
peterzhuamazon pushed a commit to peterzhuamazon/opensearch-build that referenced this pull request Feb 16, 2022
* Adding Release owner section to maintainers

Describing the intention behind being a release owner and approaches to different situations that occur during the a release.

Signed-off-by: Peter Nied <petern@amazon.com>
@peternied peternied deleted the release-owner branch March 3, 2022 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document the function of the release manager
4 participants